Skip to content

added caching for nearby baskets

Christian Walgenbach requested to merge add-caching-for-nearby-baskets into master

What does this MR do?

because loading the food baskets currently takes 1.5 seconds and happens every time the dashboard is loaded. We discussed this at the dev call and decided to introduce a caching of 5 minutes. this is what this MR.

How confident are you it won't break things if deployed?

Links to related issues

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. show in browser console in app tab for cache 'nearbyBaskets'
  4. the cache should be used for 5 minutes. only then should a new request be made via rest.

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Christian Walgenbach

Merge request reports