Skip to content

refactor profile settings to vue and rest api

Christian Walgenbach requested to merge profile-settings-to-vue-and-rest into master

Closes #1339 (closed), #1361 (closed), #1345 (closed)

What does this MR do?

  • settings page completely rebuilt in vue
  • foodsaver form from the profile for ambassadors / orga users was transferred into it
  • component for phone numbers with validation added
  • field position added
  • homeRegion chooser is only displayed for orga and ambassador users
  • role dropdown is only displayed for orga users
  • about me public and position field is only be displayed for users who are also on the team page
  • foodsharers, ambassadors and orga users can change their name. foodsaver must still ask an ambassador or orga user.

How confident are you it won't break things if deployed?

ToDo

  • remove old foodsaver edit forms
  • add role field only for orgUser
  • add homeRegion chooser for orgUser and ambassador
  • add info banner for profile.editNameInfo
  • validation for input fields - #1361 (closed)
  • test for PhoneNumber.callableNumber is broken
  • add position field
  • about me public and position field should only be displayed for users who are also on the team page
  • add quiz menu links - after quiz refactoring - !3119 (merged)
  • add logChangedSetting
  • remove column orgateam - related #904
  • show better error message for phone number input
  • use updateFoodsaver for downgradeAndBlockForQuizPermanently
  • delete accounts should possible for orga user

For a follow-up

  • field to change personal mailbox name and adress #748

Done

Links to related issues

How to test

Screenshots (if applicable)

bot user

image image image

orga user

image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports