Fix wrong formats of ACTIVITY-Listing in session
Closes #1875 (closed), #1876 (closed)
What does this MR do?
The MR showed that invalid data is stored in sessions or DB. The ACTIVITIES-LIST in session contains invalid JSON.
Additional was a problem with JSON deserialisation of a complexer structure of the array. Default behaviour creates an stdClass which can not be iterated. This is fixed by using json_decode with flag to convert data into assoziative arrays.
How confident are you it won't break things if deployed?
Links to related issues
How to test
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Alex