Skip to content

HELP NEEDED: Enabling the Display of Occupied Slot Details in the Confirmation Dialogue

Help Needed

  1. The pipeline is randomly failing in unrelated tests.
  2. I cannot set the required labels to the MR, I guess I don't have the required permissions to edit them.

Closes #1862 (closed)

What does this MR do?

Previously, only the total number of occupied slots was displayed in the dialogue. This change allows users to view detailed information, such as the date and current status of the pickup slot.

This modification facilitates store coordinators in identifying the dates a user has registered for pickup at a specific store, assisting in the decision to approve or deny the request (refer to issue #1862 (closed)).

The update also encompasses a minor layout adjustment of the dialogue. Before this change, the profile action buttons (open profile, call, etc.) were placed in a row below the two-column layout of the user avatar and the pickup request details. This arrangement caused the buttons to shift unpleasantly when details of the occupied slots were expanded, due to the additional space needed by these details pushing the button row further down.

To address this, I have repositioned the profile action buttons into the left column, directly beneath the user avatar. This adjustment not only resolves the issue of the shifting buttons but also lends a cleaner overall appearance to the dialogue.

How confident are you it won't break things if deployed?

95 %. But it is my first contribution, so...

Links to related issues

A possible technical solution to the problem outlined in #1862 (closed) and addressed by this MR, might be found by implementing store rules (refer to #1727). Nevertheless, the modifications in this MR are minimal and represent a suitable quick win to aid the manual pickup approval process until a comprehensive technical solution enforcing all diverse rules is in place. Furthermore, retaining the changes from this merge request will remain beneficial, even after the introduction of a more advanced technical rule enforcement.

How to test

  1. Checkout branch locally
  2. Login as foodsaver, assign yourself to some slots
  3. Logout
  4. Login as store coordinator
  5. Click on one of the foodsaver's slots
  6. In the confirmation dialogue check that you see all the slots the user has signed up for
  7. Check also all other functionality of the dialogue (chat, call, ...)

Screenshots

BEFORE change AFTER change

details toggled ("Aktuell belegte Slots")

tooltip example

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Closes #1862 (closed)

Edited by Kai

Merge request reports