Skip to content

Draft: Lazy load conversations when the menu is opened

Alex requested to merge 1749-lazy-load-conversations into master

Closes #1749

What does this MR do?

This is a proposal. I'm not too sure about this.

The conversations including all its avatar images are being loaded on every page, even if you don't open the menu. This adds a lot of unnecessary data transfer. I wanted to make the conversations menu lazy load its pictures but that's not easily possible with the b-avatar component. Instead, this MR makes the menu lazy load all the conversations as soon as it is opened for the first time. There is a spinner showing while the data is loading.

How confident are you it won't break things if deployed?

Pretty sure that it works, but not sure if we want this behavior

Links to related issues

#1533

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Open the conversations menu

Screenshots (if applicable)

peek

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Closes #1749

Edited by Alex

Merge request reports