Move Session Options to SettingsTransaction
What does this MR do?
The Database contains two storage for user Options/settings
The fs_foodsaver is loaded by the Login into the Session (DB cell content is deserialized into Objekt in Session). The settings are manage the Modul 'Settings'.
This MR copies the content of options into the settings, so that only one source for settings/User Options exists.
The Session Option access is removed and replaced by SettingsTransaction access.
How confident are you it won't break things if deployed?
Should not, but maybe the session makes trouble.
Links to related issues
How to test
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Anton Ballmaier