Delete inactive users
Closes #19 (closed)
What does this MR do?
In the daily mantainance script it deletes user accounts (all roles) where last_login is older then 5 years. Flag that users can manually set to exclude from automatic deletion and that is considered for deletion script.
The number of accounts deleted per night is limited by the MAX_DELETE_OLD_ACCOUNTS_PER_DAY constant, which is currently set to 1000.
How confident are you it won't break things if deployed?
better someone check
Links to related issues
How to test
- Checkout branch locally
- run database migration to add field
- run seed command
- check log outputs from the maintenance script - ./scripts/run-daily-maintenance (runs directly after seed)
deleting users inactive > 5 years
...checking 21 accounts
currently checking xxxx
user 2955 Deleted
- Login with user and set "no automatic delete"
- login as Orga and change value "no automatic delete"
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Alex