Skip to content

Delete inactive users

OnceUponAFoodsharingTime requested to merge delete_inactive_users into master

Closes #19

What does this MR do?

In the daily mantainance script it deletes user accounts (all roles) where last_login is older then 5 years. Flag that users can manually set to exclude from automatic deletion and that is considered for deletion script. Bildschirmfoto_2024-04-09_um_10.51.41 Bildschirmfoto_2024-04-09_um_10.51.49

How confident are you it won't break things if deployed?

better someone check

Links to related issues

#19

How to test

  1. Checkout branch locally
  2. run database migration to add field
  3. run seed command
  4. check log outputs from the maintenance script - ./scripts/run-daily-maintenance (runs directly after seed)
deleting users inactive > 5 years
...checking 21 accounts
currently checking xxxx
user 2955 Deleted
  1. Login with user and set "no automatic delete"
  2. login as Orga and change value "no automatic delete"

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Christian Walgenbach

Merge request reports