Skip to content

Fix Sentry's database profiling feature

Fridtjof requested to merge sentry-dbal-fix into master

What does this MR do?

When I introduced DBAL in !2801 (merged), one of the benefits I mentioned is that Sentry would integrate with it and offer us profiling for queries.

Unfortunately, that has never worked thus far:

grafik.png

After a long bug hunt, and learning way more about Symfony's inner workings than I'd ever thought I would need to know, I found the problem, opened an issue upstream (https://github.com/getsentry/sentry-symfony/issues/805) and verified this fix/workaround works in a private sentry organization.

This, after all, is how it's supposed to look! :D

grafik.png

How confident are you it won't break things if deployed?

not likely

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Fridtjof

Merge request reports