Draft: Resolve "Messages are displayed as read before reading"
What does this MR do?
Remove the side effect of marking the conversation as read from the API route used to load a conversation.
Messages were already being marked as read when the chat is opened (by clicking the new message notification) or interacted with.
How confident are you it won't break things if deployed?
Everything seems to still work correctly, but please test thoroughly.
Links to related issues
How to test
- Checkout branch locally
- Login as different users in multiple sessions
- Send messages back and forth, try out all the methods of reading a message/marking it as read
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Closes #1052