Skip to content

Draft: Resolve "Missing warning if foodsaver to be deleted is still in slot"

Closes #1825

What does this MR do?

Adding a warning, if someone removes a foodsaver from the store members. The warning is coming up, when the foodsaver is still registered in a pickup.

How confident are you it won't break things if deployed?

Very much

Links to related issues

#1825

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Register in a slot
  4. Login as a store manager
  5. Open the store
  6. Go to the members
  7. Click on the delete button of another foodsaver.
  8. The old message appears
  9. Click on the delete button of the foodsaver you where logged in in step 2
  10. A new warning appears

Screenshots (if applicable)

New warning Old warning

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by ToLei

Merge request reports