Skip to content

Move hastodoquiz to QuizXhr and remove unused variable

KoeMai requested to merge 1769-move-quiz-from-session-to-module into master

What does this MR do?

Currently with every Session refresh the state of Quiz IS loaded by the Session.

The Quiz state is related to only one Module/ helper QuizHelper.

This modification moves the Quiz related stuff to the module Quiz. The Session caching ist removed, the information ist not used offen.

This makes maintaining easier.

How confident are you it won't break things if deployed?

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Christian Walgenbach

Merge request reports