Skip to content

Disable modals in topbar when logged out

Alex requested to merge disable-modals-when-logged-out into master

What does this MR do?

Only includes the modals (join region, language chooser, ...) in the topbar when logged in. The modals try to fetch user data which fails with a 401 response when not logged in:

Error fetching user details: Error: HTTP Error 401: Unauthorized during GET http://localhost:18080/api/user/current/details

See https://yunity.slack.com/archives/C1T1ZM9A4/p1704995455081179

How confident are you it won't break things if deployed?

very sure

Links to related issues

How to test

  1. Checkout branch locally
  2. Open the start page
  3. Check in the browser console that there is no 401 error

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports