Skip to content

Fix tabbing issue on login form

Nick Sellen requested to merge fix-login-tabbing into master

Fixes https://gitlab.com/foodsharing-dev/issues0/issues/366

What does this MR do?

This reverts commit f68c2b0a.

Between 2.9.5 and 2.9.6 fullpage.js changed the way tabs are handled to fix an issue they had but it breaks tabbing in our login form. I don't fully understand the issue they had, but I think it is less bad than the issue it created for us :)

Maybe they fix it again, we should ideally file an issue ... (https://github.com/alvarotrigo/fullPage.js/issues/new).

How confident are you it won't break things if deployed?

Reasonably so.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible... easy to verify locally (sorry, bad excuse)
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s)) well the original changelog said it upgraded to 2.9.5 anyway....

Merge request reports