Skip to content

Draft: disable eslint in development

Buntel requested to merge disable-eslint-in-dev into master

What does this MR do?

Disabling eslint while in dev mode. This is pretty convenient because in development your code is unfinished and does not need to conform with the style guide. It's just annoying if you keep getting errors and need to rebuild because you missed a comma at the end of an array or something like that.

How confident are you it won't break things if deployed?

Quite sure. Only the dev mode is affected. Nothing changed for the deployment.

Links to related issues

How to test

  • start developing Vue/Javascript
  • place no comma at the end of your array -> no errors what so ever :)

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports