Refactoring buddy list management from session to module"
Closes #1768 (closed)
What does this MR do?
Refactoring of Session class to reduce dependencies.
The BuddyList is generated with each login in the session. This structure splits the Module Buddy into a Session part and a Module part. This change moves all session parts into the BuddyTransaction so that all parts are in the Module. This reduces the complexity and dependencies of the Session class.
How confident are you it won't break things if deployed?
Not expected.
Links to related issues
How to test
- Checkout branch locally
- Login as foodsaver
- Check for Feed entries of Buddies in Activities.
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Closes #1768 (closed)
Edited by Fridtjof