Skip to content

Use API for quickreplies to emails

Alex requested to merge 1668-mailbox-quickreply-rest into master

Part of #1668

What does this MR do?

Quickreplies to emails on the dashboard still use old Xhr code. This removed the Xhr code and makes the dashboard use the existing endpoint for sending emails.

How confident are you it won't break things if deployed?

Quite sure, because the endpoint is already in use by the mailbox module.

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Find an email on the dashboard
  4. Type a quickreply text and send it
  5. Check on https://localhost:18084 if the email was sent

Checklist

  • added a test, or explain why one is not needed/possible... API tests already exist
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports