Skip to content

Search improvements

Anton Ballmaier requested to merge search-improvements into master

What does this MR do?

Reworks the search function. Also resolves the visibility issues introduced by the search visibility restrictions introduced in release jackfruit.

How confident are you it won't break things if deployed?

This might be heavy on performance, it might not be. I am unsure. But testing is what the beta is for, right 🙈

Links to related issues

Discussion in Produktteam: https://beta.foodsharing.de/?page=bezirk&bid=2296&sub=forum&tid=222995 Explanation, which search results are retrieved: https://beta.foodsharing.de/?page=bezirk&bid=2296&sub=forum&tid=222995&pid=1292603#post-1292603

How to test

Screenshots (if applicable)

Screenshot_2023-10-04_at_16-23-43_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

BOTs / Admins are included in the search results for regions / working groups.

Screenshot_2023-10-04_at_16-27-13_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Screenshot_2023-10-04_at_16-26-41_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Directly message users, you can call them if you have a store team in common

Screenshot_2023-10-04_at_16-32-14_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Stores you administrate and where you are member are at the top:

Screenshot_2023-10-04_at_16-27-44_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Threads and Chats are now included in the search:

Screenshot_2023-10-04_at_16-28-06_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Screenshot_2023-10-04_at_16-28-25_Lebensmittel_teilen_statt_wegwerfen___foodsharing_Deutschland

Search is non-sensitive to dialects:

image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports