Port ContentControl to Symfony
What does this MR do?
ContentControl is ported to Symfony. I also took the opportunity to simplify a lot of the boilerplate that happened for name => ID aliases.
In the process, I moved many special URLs into Symfony routing, which means their nginx config can be removed entirely :)
It might also be helpful as an example for how controllers may be ported.
How confident are you it won't break things if deployed?
This keeps all functionality as-is (besides porting it to a symfony controller), and is only concerned with public-facing display of content.
Links to related issues
How to test
See if various URL forms pointing to content still work:
old/pre-existing:
http://localhost:18080/partner
http://localhost:18080/?page=content&sub=partner
new:
http://localhost:18080/content?sub=partner (this one is important to complete the chain from the automatically rewritten old style URL)
http://localhost:18080/content/partner
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.