Skip to content

Draft: clean up report code

OnceUponAFoodsharingTime requested to merge small_report_cleanup into master

What does this MR do?

Backend cleanup of report module

  • more distinction between report type and report reason id
  • added column report_type (the type of report (GOALS_REPORT or another type) - define ReportType
  • added column report_reason_id (reason id)
  • addBetriebReport used with report type and changed to addStoreReport
  • addReport used with report type

Removed functions:

  • getFoodsaverBetriebe (common storelist is generated elsewhere)
  • confirmReport (confirm not used)
  • getReportedSavers (not used)
  • getReportStats (not used anymore - from old all-report overview page)
  • getReportsForRegionlessByReporterRegion (not used)
  • comReport (not used anymore- from old all-report overview page)
  • NO frontend changes

How confident are you it won't break things if deployed?

Links to related issues

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Write a report
  4. Login as reportuser1@user
  5. check if you can see the report and also past reports.

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by OnceUponAFoodsharingTime

Merge request reports