Improve forum bells
requested to merge 719-fewer-notification-bells-when-following-a-discussion-overwriting-old-bell-with-new-per-thread into master
Closes #719 (closed) Requires !2827 (merged) to be in prod first
What does this MR do?
Bell you get a single notifications for any number of new forum posts in one thread. Also deleting posts adjusts the bells accordingly. Only unseen bells are ever updated, seen bells stay unchanged. The icon for bells, that indicate only a single new post is now just one speech bubble.
How confident are you it won't break things if deployed?
Quite confident, but the way prod and beta work together will produce somewhat odd looking results:
How to test
- Checkout branch locally
- Login with at least two accounts at once (to make it easier)
- Make all of them follow the same thread with bell notifications
- Send some messages, delete some, mark the notifications as read for some and so on.
- checkout master again
- Play forum simulator some more
- Switch back to this branch etc.
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Glockenbenachrichtigungen für Forenbeiträge wurden verbessert. Du erhälst jetzt nur noch eine Glocke mit der Anzahl der neuen Nachrichten. Gelöschte Posts werdeb dabei nicht mehr mitgezählt.
Edited by Anton Ballmaier