Skip to content

List common stores in report dialog

Alex requested to merge 1599-report-dialog-stores into master

Closes #1599 (closed), follow-up from !2677 (merged)

What does this MR do?

If you want to send a report on a profile page, you need to select a store. Currently, that list is empty for foodsavers, because they are not allowed to see the stores in which another user is a member. This change makes the report dialog list all stores in which the reporter and the reportee both are members, so that foodsavers can submit reports too. Ambassadors can still see the full list of stores in which the reported user is.

How confident are you it won't break things if deployed?

very sure

How to test

  1. Checkout branch locally
  2. Login as foodsaver, e.g. user2
  3. Go to another user's profile page
  4. Open the report dialog
  5. There should be some stores in the list inside the dialog

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Der Meldedialog auf der Profilseite zeigt jetzt nur noch die Betriebe an, in denen beide Personen sind.

Edited by Alex

Merge request reports