Resolve "TypeError: undefined is not an object (evaluating 'e.selectedRegion.name')"
Closes #1623 (closed)
What does this MR do?
Makes sure that the region's name of the initial value is always passed to the region chooser tree. I had to add the region's name to the store information data for this. That way it also works if the user is not a member of that region, for example if you edit a store as orga.
How confident are you it won't break things if deployed?
quite sure
How to test
You need a store that is not in the default region. Easiest way to do that is to edit one store in phpMyAdmin and set it from Göttingen to Entenhausen. Then
- Checkout branch locally
- Login as userorga
- Go to that store's page, open the information modal, and switch to the edit mode
- Check that the region chooser and the initial name is shown on the "Verwaltung" tab
- Also check that the region chooser is working on the settings page http://localhost:18080/?page=settings&sub=general and the profile edit page (Profil -> Profil bearbeiten)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Closes #1623 (closed)
Edited by Alex