Skip to content

Add Text Field to Pickup Slots

Anton Ballmaier requested to merge 1653-add-text-field-to-pickup-slots into master

Closes #1653 (closed)

What does this MR do?

It adds a feature that allows store managers to set a description for pickups (regular and one-time) to add slot details.

This feature was wished for and voted for by the Produkt Team: https://beta.foodsharing.de/?page=poll&id=1590

How confident are you it won't break things if deployed?

DB migrations always feel somewhat unsave to me, but apart from that quite confident.

How to test

  1. Checkout branch locally
  2. Login as storemanager
  3. Add a description to a pickup via menu
  4. Remove an add slots to a described pickup (description stays there)
  5. Add a new onetime pickup with description
  6. Add a regular pickup with description
  7. Enter into a regular pickup slot with description (description stays there)
  8. Remove a description

Screenshots (if applicable)

Pickups with description:

Screenshot_2023-07-09_at_11-34-22_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

Editing description and deleting moved to one menu:

Screenshot_2023-07-09_at_11-38-01_Screenshot_from_2023-07-09_11-35-47.png__PNG_Image_1864___1053_pixels____Scaled__89__

Popup when editing description:

Screenshot_2023-07-09_at_11-39-23_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

Popup when seting up single time pickup:

Screenshot_2023-07-09_at_11-36-08_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

Editing regular pickups:

Screenshot_2023-07-09_at_11-36-43_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

Same thing on smaller screens:

Screenshot_2023-07-09_at_11-37-00_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

The description gets displayed in the pickup history in the store:

Screenshot_2023-07-13_at_14-16-37_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

...in the profile pickup table in every tab (only as tooltip so that the layout doesnt get broken, but accessible in mobile as well via clicking it):

Screenshot_2023-07-13_at_15-04-05_Screenshot_from_2023-07-13_15-03-41.png__PNG_Image_1864___1053_pixels____Scaled__89__

...and also visible on the dashboard (abbreviated via ellipsis, but full text via tooltip):

Screenshot_2023-07-13_at_15-18-33_Lebensmittel_teilen_statt_wegwerfen_-_foodsharing_Deutschland

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Abholungen können jetzt von Betriebsverantwortlichen mit einem kurzen Text beschrieben werden, um beispielsweise Einführungsabholuangen oder andere spezielle Abholungen zu kennzeichnen.

Edited by Anton Ballmaier

Merge request reports