Add Text Field to Pickup Slots
Closes #1653 (closed)
What does this MR do?
It adds a feature that allows store managers to set a description for pickups (regular and one-time) to add slot details.
This feature was wished for and voted for by the Produkt Team: https://beta.foodsharing.de/?page=poll&id=1590
How confident are you it won't break things if deployed?
DB migrations always feel somewhat unsave to me, but apart from that quite confident.
How to test
- Checkout branch locally
- Login as storemanager
- Add a description to a pickup via menu
- Remove an add slots to a described pickup (description stays there)
- Add a new onetime pickup with description
- Add a regular pickup with description
- Enter into a regular pickup slot with description (description stays there)
- Remove a description
Screenshots (if applicable)
Pickups with description:
Editing description and deleting moved to one menu:
Popup when editing description:
Popup when seting up single time pickup:
Editing regular pickups:
Same thing on smaller screens:
The description gets displayed in the pickup history in the store:
...in the profile pickup table in every tab (only as tooltip so that the layout doesnt get broken, but accessible in mobile as well via clicking it):
...and also visible on the dashboard (abbreviated via ellipsis, but full text via tooltip):
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Abholungen können jetzt von Betriebsverantwortlichen mit einem kurzen Text beschrieben werden, um beispielsweise Einführungsabholuangen oder andere spezielle Abholungen zu kennzeichnen.