Skip to content

fix parsing of quoted address json

Neriton requested to merge 1551-json-exception-in-mailbox-gateway into master

Closes #1551

What does this MR do?

Fix the parsing of legacy email addresses stored with escaped quotes in JSON keys and/or values.

How confident are you it won't break things if deployed?

Pretty sure

How to test

  1. Checkout branch locally
  2. Login as ambassador
  3. Set the sender/to address of an email to one of these test values in phpmyadmin. (add enclosing square brackets for to)
{"personal": "\"____ ____\"","mailbox": "____.____","host": "example.com"}
{\"personal\":\"____@lebensmittelretten.de\",\"mailbox\":\"____\",\"host\":\"lebensmittelretten.de\"}
{"personal":"h\"____ ____\"","mailbox":"____.____","host":"lebensmittelretten.de"}
{\"personal\":\"____@web.de\",\"mailbox\":\"____\",\"host\":\"example.com.de\"}
{"mailbox":":string3____ ____\\\":string4Am____ ____:string5Antenne ____\" "}
  1. Browse the associated mailbox. Open the email.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Email-Kontos mit anders gespeicherten Adressen werden wieder angezeigt.

Edited by Neriton

Merge request reports