Added unit tests for EmailHelper and made Unicode Email-Addresses work
What does this MR do?
Introduces unit tests for the Email Helper, as nothing was tested there yet and utilities should have a certain test level of testcoverage in my opinion.
Also introduces support for Unicode Email addresses.
How confident are you it won't break things if deployed?
If the delivery pipeline and queuing mechanism can deal with unicode email addresses, it should be fine.
Links to related issues
How to test
- Execute the tests by using
./scripts/test unit EmailHelperTest
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Andre Dörscheln