Skip to content

Replace store edit/information UI with vue dialog

KoeMai requested to merge 1449-new-ui into master

Closes #1602 (closed)
Closes #1449 (closed)

What does this MR do?

This MR introduces a new UI modal dialog for the store information. The modal dialog is visible for all store members, only store manager and higher can switch into the edit view.

How confident are you it won't break things if deployed?

Not expected

Links to related issues

OldDialog CurrentStorePage

How to test

As store manager

  1. Checkout branch locally
  2. Login as store responsible foodsaver
  3. Open a managed store
  4. Open "Show store information"
  5. View elements about the store
  6. Switch to edit mode
  7. Make some changes
  8. Store it

Store manager but not for the selected store

  1. Checkout branch locally
  2. Login as store responsible foodsaver
  3. Open a store where you are only member
  4. Open "Show store information"
  5. View dialog

Foodsaver

  1. Checkout branch locally
  2. Login as foodsaver
  3. Open a store
  4. Open "Show store information"
  5. View dialog

Test Changes of address Picker

  • Use address Picker in profile settings

Screenshots (if applicable)

First drafts (Keep for links in forum)

  1. Commen information image
  2. Store information image
  3. Internal management image
  4. Internal management - change region (waiting for new component) image
  5. Pickup settings image
  6. Team settings image
  7. Statistics image

Example for (Edit mode) image

Change in Store Menu (Remove Team-Status) image

Last state of UI

image image

Open issues

  • Rework Update of Region Data field by Region selector
  • Open dialog for store members (ready only)
  • Hide empty fields for Store Members
  • Add validation of max String length in Public information
  • Translate all element in formes
  • Add Tests for endpoint Modifikation

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Überarbeitung des "Betrieb bearbeiten" Formulars

Dieser Umbau hat, dass alte Formular zum Bearbeiten des Betriebes ersetzt, um auf ein neue Backend umzustellen. Das neue Formular ist ein Dialog, welcher zur Einsicht jedem Betriebsteammitglied unter "Betriebs-Information anzeigen" angezeigt wird. Der Dialog kann in einen Bearbeiten-Modus versetzt werden, um die Betriebsinformationen durch einen Betriebsverantwortliche anpassen.

Überarbeitung des Adress-Picker

Der Adresse-Picker, welcher im Betrieb oder in den Profil-Einstellungen eingesetzt wird, erlaubt es jetzt die Geo-Position unabhängig von der Adresse zu verändern. Dies Ermöglicht es bei fehlender Hausnummer oder Position weicht von der eigentlichen Adresse diese zu korrigieren. Die Standard-Einstellung passt bei Änderung der Geo-Position und Adresse an.

Edited by KoeMai

Merge request reports