Skip to content

fix(backend): Make business card creation work in all languages

Closes #1575 (closed)

What does this MR do?

This MR resolves the issue of #1575 (closed), that no business cards could be created, if the user's language was other than German.

I introduced small optimizations: Sanitization, as well as translation clarifications as well in the business card component.

How confident are you it won't break things if deployed?

Very honest. Only small changes have been made, that affect translations and the business-card component.

Links to related issues

#1575 (closed)

How to test

  1. Choose any language but German
  2. In the profile settings choose "Personal business card"
  3. Choose a role/region to generate a business card
  4. The card will be created from the page you're (technically) redirected to

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Die persönliche Visitenkarte kann jetzt in jeder Sprache heruntergeladen werden.

Edited by Alex

Merge request reports