Skip to content

Draft: adds pagination to store rest api

Robert Nönnig requested to merge 1496-pagination-store-api-3 into master

Closes #1496

What does this MR do?

Adds the parameters startOffset and limit to the getStoresOfRegion REST API operation.

How confident are you it won't break things if deployed?

If the new parameters are not provided the first 9999 stores will be returned for backwards compatibility.

Links to related issues

Discussion about what pagination parameters to use: https://app.slack.com/client/T0B6WCFM5/C1T1ZM9A4/thread/C1T1ZM9A4-1670601740.259619

How to test

Since there is no UI change to use this feature it can only be tested on the REST API level

Screenshots (if applicable)

n/a

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Dieser Change sollte noch keine spürbare Auswirkung haben, erst wenn die neuen Pagination parameter genutzt werden, wird es spürbare Änderungen geben.

Merge request reports