Skip to content

Misc cleanup/refactor in backend base code

Fridtjof requested to merge various-base-code-cleanups into master

What does this MR do?

...A bunch of stuff. I kind of combed through the backend core (Utility, Control base code, Entrypoints) for opportunities to simplify and/or refactor.

Also, I got rid of the $g_template global, so that's neat!

Building on this, $g_data is next.

How confident are you it won't break things if deployed?

These are changes to base code, breaking it would usually be very obvious. Pretty confident :)

Links to related issues

How to test

CI run should be enough for this, but check random parts of the site for breakage if you want

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Fridtjof

Merge request reports