Skip to content

Remove the use of Flourish's fException

Peter Tönnies requested to merge Feature/PT-RemoveFFlourishExceptions into master

What does this MR do?

reduces the amount of PHP legacy stuff my removeing the use of fException. Simplified (removed) various Exception-classes from fFlourish

How confident are you it won't break things if deployed?

I do not fear anything. Worst case is a broken exception.

How to test

Test if uploading resized images in food baskets still work. Or if wrong input is throwing some nice exception still.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md (documented that inside lib. Hope this is enough)
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Peter Tönnies

Merge request reports