Optimise a database query in Rest endpoints
What does this MR do?
Several endpoints use the FoodsaverGateway::getFoodsaverBasics
function to fetch data of a foodsaver. The function uses an additional query to fetch more data, which is discarded in most cases. This replaces the usage of getFoodsaverBasics
with a new function which does not fetch any unnecessary data. Also, the new function now returns a DTO.
How confident are you it won't break things if deployed?
Links to related issues
related to #1533
How to test
If you can login, everything should be fine. The additional data was never used.
Checklist
-
added a test, or explain why one is not needed/possible... not necessary, because the data was never used -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Edited by Alex