Skip to content

Fix user id in user details REST endpoint

Alex requested to merge 1534-fix-user-details into master

Closes #1534 (closed)

What does this MR do?

The endpoint /user/{id}/details is using the id of the logged in user instead of the requested profile.

I think this is not yet used anywhere in the frontend except for your own data which is not affected by this.

How confident are you it won't break things if deployed?

Absolutely

How to test

  1. Checkout branch locally
  2. Login as userorga
  3. Open a new tab and request https://localhost:18080/api/user/{id}/details with the id of another user
  4. Check that the details regions and groups are the one from the other profile, not yours

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Closes #1534 (closed)

Merge request reports