Skip to content

MailsControl: fix content charset

Fridtjof requested to merge 1529-fix-email-charset into master

Closes #1529 (closed)

What does this MR do?

Fixes outgoing emails' content charset being set to content/mime type values instead.

Context, as explained in #1529 (closed):

This broke in 2ef4bf51 (Line 329 and 330), where we switched to SymfonyMailer from SwiftMailer. SwiftMailer expected the content type as second argument here, whereas SymfonyMailer expects the charset instead (and defaults to utf-8).

How confident are you it won't break things if deployed?

100%

Links to related issues

#1529 (closed) #1532 (closed) (should be fixed by this as well)

How to test

  1. do something that triggers outgoing mail
  2. check maildev to look at the mail, and look at the Content-Type header (charset should be utf-8)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Fridtjof

Merge request reports