Skip to content

fix using correct year for calender week

- requested to merge fix_commitment_year_change_week into master

What does this MR do?

Fixes that the correct year is used from the date. you can not use the %Y (year from the date ) in combination with %v(calender week). There are weeks that break throughout a year. The correct value is %x to use the year from the calender week.

E.g. 01.01.2022 is calender week 52 but in the year 2021

The 27.12.2022 is also week 52 but in the year 2022.

Using the year from the date would result in counting pickups from 01.01.2022 to the KW of the end of the year. Solution : The year of the calender week has to be used and not the year from the actual date.

How confident are you it won't break things if deployed?

quite

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by -

Merge request reports