scripts: address some shellcheck lints and deduplicate init code
What does this MR do?
Improves the scripts a little bit and makes the sourcing of the init code more consistent (many of them were redundantly setting options and variables that are already set in helping-functions)
Quoting is changed where it makes a functional difference (e.g. globbing/word splitting), otherwise left untouched.
How confident are you it won't break things if deployed?
Links to related issues
How to test
Checklist
-
no tests, just script changes -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Fridtjof