Skip to content

refactor(StoreCest) Removed duplicate and unnecessary elements

MS requested to merge Fix/companycest_adjustments into master

What does this MR do?

This MR cleans up some tests and improves the env.

Removed

  • tests/_data → Avatar and SQL dump (not used)
  • HtmlAcceptanceTester → Elements (not used)

Moved and removed

Tests are not removed, just migrated to StoreCest, to keep the naming consistent.

  • tests/acceptance/CompanyCest.phptests/acceptance/StoreCest.php (duplicate)
  • tests/acceptance/CreateCompanyAsFoodsaverCept.phptests/acceptance/StoreCest.php (duplicate)
  • tests/acceptance/CreateEditStoreCept.phptests/acceptance/StoreCest.php (duplicate)

Script QoL

  • scripts/test → db init is running when db is missing and boots all containers when "not 12 are running"
  • scripts/db-drop → the env can be chosen by parameter

How confident are you it won't break things if deployed?

🤷

Links to related issues

https://gitlab.com/foodsharing-dev/foodsharing/-/work_items/117280424

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by MS

Merge request reports