Bugfix: use correct user location for nearby baskets
What does this MR do?
If the user doesn't specify a location in the request for nearby baskets, the backend uses the user's profile address. This didn't work because of a small bug. This isn't in use on the website yet, but in the app.
How confident are you it won't break things if deployed?
absolutely
How to test
- On master: login as userbot
- Open your profile settings http://localhost:18080/?page=settings&sub=general and put your location close to a basket
- Check http://localhost:18080/api/baskets/nearby?distance=50, the list is probably empty
- Checkout branch locally
- Repeate 3., the basket should be listed now
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Die Liste der Essenskörbe in der Nähe wird in der App wieder vollständig angezeigt.