Commitment stat follow up
Closes #1300
What does this MR do?
- Fixes a bug in commitment stat were the shor term sign ups were countet even if a person signed out from the slot again or signed in multiple times.
- fixes a bug in commitment stat were the handshake symbol wasn't shown when a food basket has been successfully shared with others.
How confident are you it won't break things if deployed?
quite
Links to related issues
How to test
-
Short term sign up test
-
Checkout branch locally
-
Login as userbot
-
go to store
-
create a store within 20 hours timeslot
-
sing up and sign out multiple times for it
-
check the profile page that it is just 1 time countet (or not counted if you stayed signed out)
-
Handshake for picked up Food basket test
-
Login as any user who can create a food basket
-
create foodbasket
-
request same foodbasket by another user
-
relogin as original user and for the request say "successfully picked up"
-
check profile that "handshake" symbol is shown for "Die Essenskörbe wurden mit 1 Person geteilt".
Screenshots (if applicable)
Before (only short term sign ups in the picture)
After (showing correct sign ups and handshake symbol)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Edited by -