Skip to content

refactor(errorContainer): improved old avatar images message

MS requested to merge Refactor/profile-image-banner-improvment into master

What does this MR do?

This, MR sharps the error message for old avatar images, by reducing misleading wordings.

  • Corrects an edge case for empty arrays in the store (Test account, without stores, without region)

How confident are you it won't break things if deployed?

🤷

How to test

Local untestable, only if you remove the avatar test in the error container file and the user has an avatar. if (DataUser.getters.getAvatar() && !DataUser.getters.getAvatar().startsWith('/api/uploads/')) {

  1. Checkout branch locally
  2. Login as foodsaver
  3. ...

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a “for:” label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a “for:Dev” label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to “state:Beta testing”.
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by MS

Merge request reports