Skip to content

fix(storeTeam): phone number validation for null was missing

MS requested to merge BugFix/store-team-is-not-showing into master

What does this MR do?

This MR solves a problem, when a Foodsaver is not in Verified and/or in a region but remains in a store.

Only callable numbers should be visible and shown

  • Non-callable numbers produced an error
  • Non-region foodsaver produced an error

How confident are you it won't break things if deployed?

🤷

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Join a store
  4. Leave the region
  5. Check if store team is visible, and phone numbers are gone.

Screenshots (if applicable)

IN STORE (WITH REGION) IN STORE (WIHTOUT REGION)
image image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by MS

Merge request reports