Skip to content

FollowUp/dashboard-intro-missing-stats

MS requested to merge FollowUp/dashboard-intro-missing-stats into master

What does this MR do?

Through the change from the rest api api/user/current/details to serverData to request less data from the server, the stats where lost in space.

But on the dashboard where the intro field is loaded, the details are now fetched.

How confident are you it won't break things if deployed?

🔢

How to test

  1. Checkout branch locally
  2. Login a bot2
  3. create and join a pickup
  4. run scripts from below
./scripts/docker-compose run --rm --no-deps app php -f run.php Maintenance daily
./scripts/docker-compose run --rm --no-deps app php -f run.php Stats foodsaver
./scripts/docker-compose run --rm --no-deps app php -f run.php Stats betriebe
./scripts/docker-compose run --rm --no-deps app php -f run.php Stats bezirke

Checklist

  • [?] added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • [?] added an entry to CHANGELOG.md
  • [?] added a short text that can be used in the release notes
  • [?] Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Merge request reports