Feature/navigation 20
What does this MR do?
A new iteration of the Navigation and requires !2293 (merged) and !2294 (merged).
How confident are you it won't break things if deployed?
Mostly, but my biggest problem was the ChatCest
it fails without an understandable reason. But it works in the local branch … including Chrome 81, which is the testing browser.
[Facebook\WebDriver\Exception\TimeoutException] Waited for 20 secs but text 'is anyone there?' still not found
Closes #1072 (closed) because we don't show any region names on the main navigation
How to test
- Checkout branch locally
- Go on the index page
- Check the page without login
- Make the viewport smaller and bigger
- Login in as
user1@example.com
- Make the viewport smaller and bigger
- Check if the user has only 2 main menu points
- Complete the quiz
- Check if the user has now 4 main menu points
- Logout
- Login in as
userbot@example.com
oruserorga@example.com
- Test if the
Bezirk beitreten
interaction in the region menu to opens the modal again and join one - Open the search and test it
- Test if each menu point works as intended.
Screenshots (if applicable)
THIS MR | BETA | |
---|---|---|
LoggedOut | ||
Loggedin | ||
Desktop | Tablet | Smartphone |
---|---|---|
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Runde 2 der Navigation, mit einem neuen Ansatz der etwas luftiger und mehr informationen beinhaltet.
Edited by MS