Skip to content

Resolve "Burger menu closes wrong"

MS requested to merge 1289-burger-menu-closes-wrong into master

Closes #1289 (closed)

What does this MR do?

Should fix the behavior by disabling some links.

  • Removed the hide Toggle because bootstrap toggles already
  • Disabled the click event on not clickable elements.
  • Added a small personal touch
  • Global store for the Language Selector to toggle from everywhere

How confident are you it won't break things if deployed?

💯

How to test

  1. Click on burger menu
  2. Click on profile, somewhere outside the menu or language selector.

Screenshots (if applicable)

BETA THIS MR
beta.foodsharing.de__iPhone_12_Pro___1_ localhost_18080__iPhone_12_Pro_

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by MS

Merge request reports