Skip to content

Resolve "Content too broad"

Christian Nienhaus requested to merge 1280-content-too-broad into master

Closes #1280 (closed)

What does this MR do?

Force content which is too broad to scroll, so the the Topbar will never leave the screen width.

How confident are you it won't break things if deployed?

It should not break anything, because normally no page should oversize the content.

Links to related issues

How to test

  1. Checkout branch locally
  2. Reduce screen size with dev tools and activate touch mode(this forces a little bit different behaviour on the Topbar position:fixed)
  3. Change text content on the start page with the dev tools and check that no content is overlapping the screen size and the Topbar is completely visible.
  4. Login as foodsaver
  5. Check the All Stores page and check again Topbar

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
    • No test possible because it is just a visual change.
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Die Navigationsleiste wird jetzt nicht mehr außerhalb des Bildschirms angezeigt.

Edited by Christian Nienhaus

Merge request reports