Skip to content

Show E-Mail attachment Icon only when there is an attachment

Closes #926 (closed) Closes #1247 (closed)

What does this MR do?

Fixes the check for no attachments. Also adjusts the test data to match the production data base.

How confident are you it won't break things if deployed?

100%. 90% confident it actually fixes the issue.

How to test

  1. Checkout branch locally
  2. Seed your db
  3. Login as userbot (has mails)
  4. See, that no mails are displayed with an attachment
  5. You might want to edit attach value in the database to '[test]' for example and check that there is now an attachment icon.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Das Anhang-Icon wird nun nur noch in Mails angezeigt, die tatsächlich einen Anhang haben.

Edited by Anton Ballmaier

Merge request reports