Skip to content

Fix vue on settings subpage

Alex requested to merge 1239-fix-settings-vue into master

Closes #1239 (closed)

What does this MR do?

Fixes that the vue component 'name-input' is only added to the subpage 'general' in the settings module. On every other subpage this caused javascript to not load correctly.

How confident are you it won't break things if deployed?

Absolutely

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to http://localhost:18080/?page=settings&sub=general and make sure that the name fields are visible
  4. Go to any other subpage and make sure that vue components are being loaded, for example the button for push messages on http://localhost:18080/?page=settings&sub=info

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Ein Problem, wegen dem einige Elemente unter "Deine Daten/Einstellungen" nicht angezeigt wurden, ist behoben.

Merge request reports