Skip to content

Draft: fetch weight table fixed

OnceUponAFoodsharingTime requested to merge expandweight into master

What does this MR do?

  • fixes the gap of KG in the list (30-40kg was missing)
  • adds more KG to the list
  • fixes the fs_fetchweight table so it can be used
  • fix seed data for categories
  • fix seed data for fs_fetchweight

How confident are you it won't break things if deployed?

Quite

Links to related issues

How to test

  1. Checkout branch locally
  2. drop and init db so that the field to fs_fetchweight table is added
  3. seed data
  4. login as ambassador or store manager
  5. go to a store you are responsible for and check the drop down list
  6. save and edit -->

Screenshots (if applicable)

image

Database migration needed

  • table fs_fetchweight add name column (varchar 50)

ALTER TABLE `fs_fetchweight` ADD `name` VARCHAR(50) NULL DEFAULT NULL AFTER `weight`;

  • add weight values.
Delete FROM fs_fetchweight;

INSERT INTO 
fs_fetchweight 
(`id`, `weight`, `name`) 
VALUES 
('0', '0', 'Keine Angabe'), 
('1', '2', '1 - 3 kg'),
('2', '4', '3 - 5 kg'),
('3', '7.5', '5 - 10 kg'),
('4', '15', '10 - 20 kg'),
('5', '25', '20 - 30 kg'),
('6', '35', '30 - 40 kg'),
('7', '45', '40 - 50 kg'),
('8', '62.5', '50 - 75 kg'),
('9', '87.5', '75 - 100 kg'),
('10', '110', 'mehr als 100 kg');
  • replace in fs_store the stores with abholmenge from id 6 to id 7
  • replace in fs_store the stores with abholmenge from id 7 to id 8

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by OnceUponAFoodsharingTime

Merge request reports