Remove padding in web push notifications
Closes #1213 (closed)
What does this MR do?
Disables automatic padding in web push messages. The padding is likely the reason for "Payload too large" errors.
See https://stackoverflow.com/questions/65018704/mozilla-push-service-413-request-entity-too-large and https://github.com/web-push-libs/web-push-php/issues/108
I'm not really sure if this fixes it, because it is difficult to reproduce the error in docker, but it is worth a try.
How confident are you it won't break things if deployed?
Not very sure. It doesn't seem break anything in docker.
How to test
- Checkout branch locally
- Login as foodsaver
- Enable push notifications on the dashboard
- Login as someone else in a private tab
- Send a message to the first user
- See that the push notification arrives
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.