Kebab-case names for emitted Vue events
Closes #996 (closed)
What does this MR do?
Changes all camelCase names of Vue events to kebab-case. Also adds the rules v-on-event-hyphenation and custom-event-name-casing to the Javascript linter. These are recommended in Vue 3.
How confident are you it won't break things if deployed?
Very sure
How to test
- Checkout branch locally
- Run
./scripts/lint-js, which should not show any errors - Test if the following things still work
- Opening the search in the topbar
- Removing a basket request
- Marking a bell as read by clicking it
- Dashboard entries reload after changing the filters
- Deleting posts on store walls
- The vote in a poll can be submitted as soon as all options are selected
- After successful registration, the registration form leads back to the login
- Adding and removing reactions to forum posts
- Activating bell and email notifications in a forum thread and making it sticky
When I tested them, they all still worked as expected.
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
used "state:" labels to track this MR's state until it was beta tested -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.