Set a timeout on sending websocket messages
Closes #1069 (closed)
What does this MR do?
Sets a timeout when sending a chat messages into a websocket. It is set to 30 seconds which will I think will never be too short. But it might prevent the server from deadlocks like last year (https://devblog.foodsharing.de/2021/03/30/outage-post-mortem.html).
How confident are you it won't break things if deployed?
Quite sure
How to test
I don't know. Best case scenario is that we don't ever notice this, so we also can't test this. You can set the timeout to a very small value and see if there is an error when sending a chat message.
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
used "state:" labels to track this MR's state until it was beta tested -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes(for:Dev) -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.